feat(framework): Validate FAB include/exclude pattern lists in app config#6803
Open
chongshenng wants to merge 6 commits intomainfrom
Open
feat(framework): Validate FAB include/exclude pattern lists in app config#6803chongshenng wants to merge 6 commits intomainfrom
chongshenng wants to merge 6 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds stricter validation for optional FAB file pattern configuration fields in pyproject.toml, ensuring [tool.flwr.app].fab-include and fab-exclude are well-formed without changing flwr build behavior.
Changes:
- Introduce constants for the
fab-include/fab-excludeconfig keys. - Add validation ensuring
fab-include/fab-exclude(when present) are lists of non-empty strings. - Add unit tests covering valid patterns and invalid types/items.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| framework/py/flwr/common/constant.py | Adds constants for FAB include/exclude config key names. |
| framework/py/flwr/common/config.py | Implements pattern-list validation and wires it into existing config field validation. |
| framework/py/flwr/common/config_test.py | Adds tests for valid/invalid fab-include and fab-exclude inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
the
Maintainer
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds config validation for
[tool.flwr.app].fab-includeandfab-exclude: if set, they must be lists of non-empty strings (for example,fab-include = ["**/*.py"],fab-exclude = ["tests/**"]; invalid:fab-include = "src/**"orfab-exclude = ["", 123]). There are noflwr buildbehavior changes.