feat(framework): Allow ServerAppExecPlugin to support both flwr-serverapp and flwr-simulation#6806
Merged
danieljanes merged 10 commits intomainfrom Mar 24, 2026
Merged
feat(framework): Allow ServerAppExecPlugin to support both flwr-serverapp and flwr-simulation#6806danieljanes merged 10 commits intomainfrom
ServerAppExecPlugin to support both flwr-serverapp and flwr-simulation#6806danieljanes merged 10 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates SuperExec support so a single ServerAppExecPlugin can launch either flwr-serverapp or flwr-simulation based on a run’s run_type, enabling one SuperLink to support both runtimes.
Changes:
- Remove
SimulationExecPluginand route simulation launches throughServerAppExecPlugin. - Update
flower-superexecwiring andExecPluginTypeto drop the dedicatedsimulationplugin type. - Adjust simulation/server entrypoints and tests to use the unified plugin approach.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| framework/py/flwr/supercore/superexec/plugin/simulation_exec_plugin.py | Removes the dedicated simulation exec plugin. |
| framework/py/flwr/supercore/superexec/plugin/serverapp_exec_plugin.py | Adds run-type-based selection of flwr-serverapp vs flwr-simulation. |
| framework/py/flwr/supercore/superexec/plugin/base_exec_plugin_test.py | Updates test run fixture to include run_type. |
| framework/py/flwr/supercore/superexec/plugin/init.py | Stops exporting SimulationExecPlugin. |
| framework/py/flwr/supercore/cli/flower_superexec.py | Removes simulation plugin type mapping. |
| framework/py/flwr/simulation/app.py | Uses ServerAppExecPlugin and serverapp plugin type for the deprecation path. |
| framework/py/flwr/server/app.py | Always starts flower-superexec with --plugin-type serverapp. |
| framework/py/flwr/common/constant.py | Removes ExecPluginType.SIMULATION. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
framework/py/flwr/supercore/superexec/plugin/base_exec_plugin_test.py
Outdated
Show resolved
Hide resolved
danieljanes
reviewed
Mar 22, 2026
framework/py/flwr/supercore/superexec/plugin/base_exec_plugin_test.py
Outdated
Show resolved
Hide resolved
jafermarq
reviewed
Mar 24, 2026
jafermarq
reviewed
Mar 24, 2026
danieljanes
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last missing piece to make one SuperLink support both runtimes.