Add JSON log serialization #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/lib.rs
This commit allows users to configure the maximum size of a single message. If a message is over the configured size, it will be ignored and not sent to Loki. Useful for avoiding congestion on slow or unreliable networks. Defaults to None, meaning no limit.
Enabling the flag also enables the JSON feature, as serde-json is required to serialize the message.
# Conflicts: # Cargo.toml
|
1.60.0 error appears to be tokio's MSRV bump to 1.63.0, unrelated to this PR. |
|
Accidentally pushed a commit to the wrong branch, had to do a force-push to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locked behind the
json-log-fmtfeature flag, requires serde-json so also enables thejsonfeature flag. Could probably also add a conditional to the actualFenrirBuilder, but given people will likely be deploying this in prod, they would either want it on for all their services or off, so I saw no reason to add that.Sorry about the first commit not having gitmoji, forgot about that and wasn't able to fix it up as I had already pushed new commits by that point.