Set the max parallelism on the execution model correctly when trigger…

…ed by launch plan (#6266) * Set the max parallelism on the execution model correctly Signed-off-by: Jason Parraga <[email protected]> * lint Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]>
flyteorg · Feb 26, 2025 · d609017 · d609017
1 parent 9225677
commit d609017
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/flyteadmin/pkg/manager/impl/execution_manager.go b/flyteadmin/pkg/manager/impl/execution_manager.go
@@ -1076,6 +1076,9 @@ func (m *ExecutionManager) launchExecution(
 		notificationsSettings = make([]*admin.Notification, 0)
 	}
 
+	// Set the max parallelism based on the execution config (calculated based on multiple levels of settings)
+	requestSpec.MaxParallelism = executionConfig.GetMaxParallelism()
+
 	createExecModelInput := transformers.CreateExecutionModelInput{
 		WorkflowExecutionID: workflowExecutionID,
 		RequestSpec:         requestSpec,

diff --git a/flyteadmin/pkg/manager/impl/execution_manager_test.go b/flyteadmin/pkg/manager/impl/execution_manager_test.go
@@ -59,6 +59,7 @@ const (
 	principal             = "principal"
 	rawOutput             = "raw_output"
 	executionClusterLabel = "execution_cluster_label"
+	launchPlanParallelism = int32(42)
 )
 
 var spec = testutils.GetExecutionRequest().GetSpec()
@@ -179,6 +180,8 @@ func getMockExecutionsConfigProvider() runtimeInterfaces.Configuration {
 
 func setDefaultLpCallbackForExecTest(repository interfaces.Repository) {
 	lpSpec := testutils.GetSampleLpSpecForTest()
+
+	lpSpec.MaxParallelism = launchPlanParallelism
 	lpSpec.Labels = &admin.Labels{
 		Values: map[string]string{
 			"label1": "1",
@@ -319,6 +322,7 @@ func TestCreateExecution(t *testing.T) {
 			assert.True(t, proto.Equal(spec.GetClusterAssignment(), &clusterAssignment))
 			assert.Equal(t, "launch_plan", input.LaunchEntity)
 			assert.Equal(t, spec.GetMetadata().GetSystemMetadata().GetNamespace(), "project-domain")
+			assert.Equal(t, launchPlanParallelism, spec.GetMaxParallelism())
 			return nil
 		})
 	setDefaultLpCallbackForExecTest(repository)