Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memray docs #5971

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Add memray docs #5971

merged 3 commits into from
Feb 13, 2025

Conversation

fiedlerNr9
Copy link
Contributor

This PR:

Why are the changes needed?

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

welcome bot commented Nov 8, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.87%. Comparing base (d3a34ed) to head (9023fec).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5971   +/-   ##
=======================================
  Coverage   36.87%   36.87%           
=======================================
  Files        1318     1318           
  Lines      134647   134647           
=======================================
+ Hits        49647    49648    +1     
+ Misses      80679    80678    -1     
  Partials     4321     4321           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 51.96% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.22% <ø> (ø)
unittests-flyteplugins 54.02% <ø> (ø)
unittests-flytepropeller 42.78% <ø> (ø)
unittests-flytestdlib 55.35% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ppiegaze
ppiegaze previously approved these changes Nov 11, 2024
@davidmirror-ops
Copy link
Contributor

@ppiegaze any idea why the test here fails trying to import wandb?

wild-endeavor
wild-endeavor previously approved these changes Feb 12, 2025
@wild-endeavor wild-endeavor dismissed stale reviews from ppiegaze and themself via 9023fec February 12, 2025 21:28
@flyte-bot
Copy link
Collaborator

flyte-bot commented Feb 12, 2025

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

@wild-endeavor wild-endeavor merged commit b04df59 into master Feb 13, 2025
53 checks passed
Copy link

welcome bot commented Feb 13, 2025

Congrats on merging your first pull request! 🎉

@wild-endeavor wild-endeavor deleted the add-memray-docs branch February 13, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants