Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels and annotations to with_overrides #6145

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
+22,807 −22,691
Draft

Add labels and annotations to with_overrides #6145

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e27e6f
WIP
pryce-turner Jan 6, 2025
8a599bf
Added correct proto path
pryce-turner Jan 13, 2025
f939634
Generated protos
pryce-turner Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions flyteidl/protos/flyteidl/core/workflow.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import "flyteidl/core/literals.proto";
import "flyteidl/core/tasks.proto";
import "flyteidl/core/types.proto";
import "flyteidl/core/security.proto";
import "flyteidl/admin/common.proto";
import "google/protobuf/duration.proto";
import "google/protobuf/wrappers.proto";

Expand Down Expand Up @@ -199,6 +200,10 @@ message NodeMetadata {
oneof cache_serializable_value {
bool cache_serializable = 9;
}

Labels labels = 10;

Annotations annotations = 11;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Labels labels = 10;
Annotations annotations = 11;
flyteidl.admin.Labels labels = 10;
flyteidl.admin.Annotations annotations = 11;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come RetryStrategy can be inferred from literals but Labels and Annotations can't be inferred from common?

}

// Links a variable to an alias.
Expand Down
Loading