[WIP] [Feature] Enable memory increase on OOM failure

[Mecoli1219]

Tracking issue

#2234

Why are the changes needed?

This is not completed yet.

What changes were proposed in this pull request?

• Update flyteidl with new field add_value_on_oom to specify whether enabling vertical pod scaling on OOM failures
• Update some code to compute the updated memory usage when creating k8s pod
• Update FlyteAdmin to let the user know the pod is updated with higher memory usage. (Perhaps could be done with OOMFailures fields?)
• Add unit tests
• ...

How was this patch tested?

Labels

• added: For new features.

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

[flyte-bot]

Code Review Agent Run Status

• Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 75 lines in your changes missing coverage. Please review.

Project coverage is 36.89%. Comparing base (8fc3b5b) to head (253fadb).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...yteworkflow/v1alpha1/mocks/ExecutableNodeStatus.go	33.33%	22 Missing and 2 partials ⚠️
.../flyteworkflow/v1alpha1/mocks/MutableNodeStatus.go	0.00%	18 Missing ⚠️
...plugins/go/tasks/pluginmachinery/flytek8s/utils.go	42.10%	9 Missing and 2 partials ⚠️
...ginmachinery/core/mocks/task_execution_metadata.go	66.66%	4 Missing and 2 partials ⚠️
...ler/pkg/apis/flyteworkflow/v1alpha1/node_status.go	0.00%	6 Missing ⚠️
flytepropeller/pkg/controller/nodes/executor.go	0.00%	3 Missing and 1 partial ⚠️
flyteadmin/pkg/manager/impl/util/resources.go	0.00%	3 Missing ⚠️
...ller/pkg/controller/nodes/task/taskexec_context.go	60.00%	2 Missing ⚠️
.../plugins/k8s/kfoperators/common/common_operator.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6263      +/-   ##
==========================================
+ Coverage   36.87%   36.89%   +0.02%     
==========================================
  Files        1318     1318              
  Lines      134829   134994     +165     
==========================================
+ Hits        49723    49811      +88     
- Misses      80772    80841      +69     
- Partials     4334     4342       +8     

Flag	Coverage Δ
unittests-datacatalog	51.58% <ø> (ø)
unittests-flyteadmin	51.88% <75.00%> (+0.03%)	⬆️
unittests-flytecopilot	30.99% <ø> (ø)
unittests-flytectl	62.33% <ø> (+0.04%)	⬆️
unittests-flyteidl	7.22% <ø> (ø)
unittests-flyteplugins	54.03% <58.13%> (+0.04%)	⬆️
unittests-flytepropeller	42.81% <22.85%> (-0.05%)	⬇️
unittests-flytestdlib	55.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[flyte-bot]

Code Review Agent Run Status

• Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

[flyte-bot]

Code Review Agent Run Status

• Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].