Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bound inputs to array node idl #6276

Merged
merged 1 commit into from
Feb 26, 2025
Merged

add bound inputs to array node idl #6276

merged 1 commit into from
Feb 26, 2025

Conversation

pvditt
Copy link
Contributor

@pvditt pvditt commented Feb 26, 2025

Why are the changes needed?

  • setting up adding support for binding inputs for array node

What changes were proposed in this pull request?

  • add bound_inputs field to array node spec

How was this patch tested?

n/a

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@pvditt pvditt added the added Merged changes that add new functionality label Feb 26, 2025
@pvditt pvditt marked this pull request as ready for review February 26, 2025 21:23
@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.89%. Comparing base (d609017) to head (67032bf).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/core/workflow.pb.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6276      +/-   ##
==========================================
- Coverage   36.89%   36.89%   -0.01%     
==========================================
  Files        1318     1318              
  Lines      134886   134891       +5     
==========================================
- Hits        49770    49764       -6     
- Misses      80780    80791      +11     
  Partials     4336     4336              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 51.85% <ø> (-0.03%) ⬇️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.22% <0.00%> (-0.01%) ⬇️
unittests-flyteplugins 54.04% <ø> (ø)
unittests-flytepropeller 42.86% <ø> (ø)
unittests-flytestdlib 55.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvditt pvditt merged commit 9b2ced5 into master Feb 26, 2025
49 of 51 checks passed
@pvditt pvditt deleted the upstream-idl-change branch February 26, 2025 21:53
@flyte-bot
Copy link
Collaborator

flyte-bot commented Feb 26, 2025

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Code Review Agent couldn't review this pull request because it is no longer valid. It may have been merged, or the source/target branch may not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added Merged changes that add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants