Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Housekeeping] upgrade go_generate ci #6279

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

taieeuu
Copy link
Contributor

@taieeuu taieeuu commented Feb 27, 2025

Tracking issue

Why are the changes needed?

let the go.mod clearly

What changes were proposed in this pull request?

How was this patch tested?

all test pass

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

Dependency cleanup and optimization of Go modules through implementation of 'go mod tidy' in golang test targets script. Removed unused indirect dependencies from go.mod and corresponding go.sum entries to streamline the dependency tree and improve maintainability.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 4

Signed-off-by: taieeuu <[email protected]>
Signed-off-by: taieeuu <[email protected]>
Signed-off-by: taieeuu <[email protected]>
Signed-off-by: taieeuu <[email protected]>
@flyte-bot
Copy link
Collaborator

flyte-bot commented Feb 27, 2025

Code Review Agent Run #5d78bd

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: ddad731..0621531
    • boilerplate/flyte/golang_test_targets/go-gen.sh
    • go.mod
    • go.sum
  • Files skipped - 0
  • Tools
    • Golangci-lint (Linter) - ✖︎ Failed
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

AI Code Review powered by Bito Logo

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.91%. Comparing base (588ceec) to head (0621531).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6279       +/-   ##
===========================================
- Coverage   50.37%   36.91%   -13.47%     
===========================================
  Files        1170     1318      +148     
  Lines       92851   134935    +42084     
===========================================
+ Hits        46774    49811     +3037     
- Misses      41931    80787    +38856     
- Partials     4146     4337      +191     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 51.87% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (-0.05%) ⬇️
unittests-flyteidl 7.22% <ø> (?)
unittests-flyteplugins 54.13% <ø> (ø)
unittests-flytepropeller 42.86% <ø> (ø)
unittests-flytestdlib 55.35% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flyte-bot
Copy link
Collaborator

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Other Improvements - Dependency Management and Module Cleanup

go-gen.sh - Added go mod tidy command to clean up dependencies

go.mod - Removed multiple unused dependencies and their indirect references

go.sum - Cleaned up corresponding dependency checksums

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants