Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic template that uses ImageSpec #43
Add basic template that uses ImageSpec #43
Changes from 18 commits
325bc28
98386cb
887f6e9
e520fd9
ef4bbce
1181312
4a2e91a
fec9410
22afbdc
b1c54eb
052ed03
34f2d8d
82d2de3
93276e9
66447e8
3c4accd
d685c3f
a664954
eccf029
5701706
3df5582
d001f54
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why we're adding the
hello-world
example, but the template name is not matching (hello_world
instead ofhello-world
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a
hello-world
example in response to this feedback on the new onboarding docs, and went into a bit more detail on my changes here. I'll update the template name, thanks for flagging!