Update default template used by pyflyte init #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikki everett <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
neverett
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2041 +/- ##
=======================================
Coverage 85.76% 85.76%
=======================================
Files 313 313
Lines 23426 23426
Branches 3510 3510
=======================================
Hits 20092 20092
Misses 2727 2727
Partials 607 607 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 12, 2023
neverett
requested review from
wild-endeavor,
kumare3,
pingsutw and
cosmicBboy
as code owners
eapolinario
previously approved these changes
Jan 2, 2024
pingsutw
previously approved these changes
Jan 4, 2024
Signed-off-by: nikki everett <[email protected]>
added 2 commits
January 4, 2024 13:33
Signed-off-by: nikki everett <[email protected]>
pingsutw
approved these changes
Jan 4, 2024
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The updated onboarding docs assume that running
pyflyte inituses a default template that makes use of ImageSpec, which doesn't currently exist.flyteorg/flytekit-python-template#43 adds a basic ImagSpec template, and this PR switches the default template to that one.
What changes were proposed in this pull request?
Switches the default template used by
pyflyte initto the new basic-template-imagespec added byflyteorg/flytekit-python-template#43
Check all the applicable boxes
Related PRs
flyteorg/flytekit-python-template#43 should be merged first.