Enable using positional args for workflow with default value

[machichima]

Tracking issue

flyteorg/flyte#6208

Why are the changes needed?

Remove the value in input_kwargs (which contains the default value) if the value is set in args, to prevent passing kwargs and args both for same argument, which cause the error described in the issue.

What changes were proposed in this pull request?

How was this patch tested?

Add test test_positional_args_workflow_with_default_value extend from test_positional_args_task for positional arguments with default value set

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This PR addresses subworkflow argument handling by preventing simultaneous use of positional arguments and default values. The workflow execution logic has been modified to properly handle input_kwargs when positional arguments are provided. Test coverage has been enhanced to validate subworkflow behavior, including test cases for mixed positional and default arguments scenarios, extra arguments handling, and keyword arguments validation.

Unit tests added: True

Estimated effort to review (1-5, lower is better): 2

[flyte-bot]

Code Review Agent Run #a46a9e

Actionable Suggestions - 1

• flytekit/core/workflow.py - 1

  • Consider using dict.pop for efficiency · Line 304-308

Review Details

• Files reviewed - 2 · Commit Range: b823ba0..50af9c3

  • flytekit/core/workflow.py
  • tests/flytekit/unit/core/test_serialization.py
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

AI Code Review powered by

[flyte-bot]

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
Feature Improvement - Enhanced Workflow Argument Handling	- workflow.py - Added validation for positional arguments and proper handling of default values in workflow calls - test_serialization.py - Added comprehensive tests for workflow positional arguments with default values and argument validation

[eapolinario]

Thank you, this looks pretty good, just a couple of nits.

[eapolinario]

can you also add a case where we invoke sub_wf with a mix of positional args and default values? For example:

    @workflow
    def wf_mixed_positional_and_default_args() -> int:
        return sub_wf(arg1)

[Future-Outlier]

lgtm, just use debugger to check the whole process, thank you @machichima

[flyte-bot]

Code Review Agent Run #abe196

Actionable Suggestions - 2

• tests/flytekit/unit/core/test_serialization.py - 2

  • Default values removed from test workflow · Line 1091-1091
  • Extra arguments passed to workflow function · Line 1096-1096

Review Details

• Files reviewed - 1 · Commit Range: 50af9c3..ced38bd

  • tests/flytekit/unit/core/test_serialization.py
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

AI Code Review powered by

[eapolinario]

This looks great, thank you!