Skip to content

Commit

Permalink
fix flytesnacks CI issues (#1480)
Browse files Browse the repository at this point in the history
* install latest flyteidl from flyte repo

Signed-off-by: Niels Bantilan <[email protected]>

* Run with tmate enabled

Signed-off-by: Eduardo Apolinario <[email protected]>

* Move tmate stanza and add failure check

Signed-off-by: Eduardo Apolinario <[email protected]>

* Reclaim space prior to running e2e tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* update data_types_and_io dockerfile flytekit version

Signed-off-by: Niels Bantilan <[email protected]>

* use torch cpu

Signed-off-by: Niels Bantilan <[email protected]>

* update kfpytorch example deps

Signed-off-by: Niels Bantilan <[email protected]>

* update kfpytorch plugin and datatypes io deps

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
  • Loading branch information
cosmicBboy and eapolinario authored Feb 8, 2024
1 parent 6cb6e6b commit d8b08dc
Show file tree
Hide file tree
Showing 6 changed files with 100 additions and 188 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ jobs:
FLYTESNACKS_VERSION: ""
timeout-minutes: 30
steps:
- uses: insightsengineering/disk-space-reclaimer@v1
- name: Set latest Flytesnacks release
if: ${{ env.FLYTESNACKS_VERSION == '' }}
run: |
Expand Down Expand Up @@ -233,3 +234,6 @@ jobs:
--version ${{ env.FLYTESNACKS_VERSION }} \
flytesnacks/$line;
done < flyte_tests.txt
- name: Setup tmate session
if: ${{ failure() }}
uses: mxschmitt/action-tmate@v3
2 changes: 2 additions & 0 deletions .github/workflows/monodocs_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,10 @@ jobs:
conda install -c conda-forge conda-lock
conda-lock install -n monodocs-env monodocs-environment.lock.yaml
- shell: bash -el {0}
working-directory: ${{ github.workspace }}/flyte
run: |
conda activate monodocs-env
pip install ./flyteidl
conda info
conda list
conda config --show-sources
Expand Down
3 changes: 2 additions & 1 deletion examples/data_types_and_io/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ ENV VENV /opt/venv
RUN python3 -m venv ${VENV}
ENV PATH="${VENV}/bin:$PATH"

RUN pip install flytekit==1.10.1 torch
RUN pip install flytekit==1.10.3 pandas
RUN pip install torch --index-url https://download.pytorch.org/whl/cpu

# Copy the actual code
COPY . /root
Expand Down
2 changes: 2 additions & 0 deletions examples/kfpytorch_plugin/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ ENV PATH="${VENV}/bin:$PATH"
# Install Python dependencies
COPY requirements.txt /root
RUN pip install -r /root/requirements.txt
RUN pip install torch torchvision --index-url https://download.pytorch.org/whl/cpu
RUN pip install tensorboardX

# Copy the actual code
COPY . /root/
Expand Down
4 changes: 1 addition & 3 deletions examples/kfpytorch_plugin/requirements.in
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
flytekit==1.10.3
flytekitplugins-kfpytorch
flytekitplugins-envd
tensorboardX
torch
torchvision
matplotlib
Loading

0 comments on commit d8b08dc

Please sign in to comment.