Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODINVSTOR-1170. Extend inventory hierarchy response with new display… #985

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

SerhiiNosko
Copy link
Contributor

@SerhiiNosko SerhiiNosko commented Feb 22, 2024

Purpose

Extend inventory hierarchy response with new displaySummary field

Approach

https://folio-org.atlassian.net/browse/MODINVSTOR-1170

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

List any Jira issues related to this pull request.

Learning and Resources (if applicable)

Discuss any research conducted during the development of this pull request. Include links to relevant blog posts, patterns, libraries, or addons that were used to solve the problem.

Screenshots (if applicable)

If this pull request involves any visual changes or new features, consider including screenshots or GIFs to illustrate the changes.

@@ -166,6 +166,7 @@ WITH
'volume', item.jsonb ->> 'volume',
'enumeration', item.jsonb ->> 'enumeration',
'chronology', item.jsonb ->>'chronology',
'displaySummary', item.jsonb ->>'displaySummary',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified existing view, because schema.json already has declaration to execute this view for Q release:
https://github.com/folio-org/mod-inventory-storage/blob/master/src/main/resources/templates/db_scripts/schema.json#L1154

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@SerhiiNosko SerhiiNosko merged commit af04ce1 into master Feb 23, 2024
6 checks passed
@GeloPakDev1 GeloPakDev1 deleted the MODINVSTOR-1170 branch February 25, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants