MODLD-894: Index new hubs in mod-search #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the resource event publishing system to support indexing new hubs in mod-search. The changes extract event publishing logic into a dedicated service that can intelligently identify and publish events for hub resources.
- Introduces
ResourceEventsPublisherinterface and implementation to centralize event publishing - Replaces direct
ApplicationEventPublisherusage with the new abstraction across service classes - Adds logic to identify and create events for new hub resources recursively
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ResourceEventsPublisher.java | New interface defining methods for publishing resource events |
| ResourceEventsPublisherImpl.java | Implementation that delegates to ResourceEventsProvider for event creation |
| ResourceEventsProvider.java | Internal interface for generating resource events |
| ResourceEventsProviderImpl.java | Core logic for identifying hub resources and creating appropriate events |
| ResourceServiceImpl.java | Updated to use new ResourceEventsPublisher instead of direct ApplicationEventPublisher |
| ResourceMarcBibServiceImpl.java | Updated to use new ResourceEventsPublisher instead of direct ApplicationEventPublisher |
| ResourceServiceImplTest.java | Test updates to verify new event publishing behavior |
| ResourceMarcBibServiceImplTest.java | Test updates to verify new event publishing behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/java/org/folio/linked/data/service/resource/events/ResourceEventsProviderImpl.java
Outdated
Show resolved
Hide resolved
pkjacob
force-pushed
the
pjacob/MODLD-894
branch
from
2741072 to
0be5c29
Compare
pkjacob
force-pushed
the
pjacob/MODLD-894
branch
from
0be5c29 to
22c11c9
Compare
PBobylev
reviewed
Oct 14, 2025
src/main/java/org/folio/linked/data/configuration/kafka/KafkaProducerConfiguration.java
Show resolved
Hide resolved
src/main/java/org/folio/linked/data/mapper/kafka/search/HubSearchMessageMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/linked/data/mapper/kafka/search/HubSearchMessageMapper.java
Show resolved
Hide resolved
src/main/java/org/folio/linked/data/service/rdf/RdfImportServiceImpl.java
Show resolved
Hide resolved
src/main/java/org/folio/linked/data/service/resource/events/ResourceEventsPublisherImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/linked/data/service/resource/events/ResourceEventsProviderImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/linked/data/service/resource/events/ResourceEventsProviderImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/linked/data/service/resource/events/ResourceEventsProviderImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/linked/data/service/resource/events/ResourceEventsProviderImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/linked/data/service/resource/events/ResourceEventsProviderImpl.java
Outdated
Show resolved
Hide resolved
pkjacob
force-pushed
the
pjacob/MODLD-894
branch
from
a72cf4d to
a993624
Compare
PBobylev
reviewed
Oct 15, 2025
src/main/java/org/folio/linked/data/service/resource/events/ResourceEventsPublisherImpl.java
Outdated
Show resolved
Hide resolved
pkjacob
force-pushed
the
pjacob/MODLD-894
branch
4 times, most recently
from
2db4a7e to
f4eb19f
Compare
pkjacob
force-pushed
the
pjacob/MODLD-894
branch
from
f4eb19f to
51c0c0c
Compare
…ed resources & use it for emitting events
pkjacob
force-pushed
the
pjacob/MODLD-894
branch
2 times, most recently
from
0ebf547 to
b041f72
Compare
pkjacob
commented
Oct 16, 2025
src/test/java/org/folio/linked/data/service/resource/ResourceServiceImplTest.java
Show resolved
Hide resolved
pkjacob
requested review from
PBobylev
and removed request for
PBobylev and
zepheiryan
pkjacob
force-pushed
the
pjacob/MODLD-894
branch
from
406b810 to
ec3dd8f
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/resources/swagger.api/folio-modules/search/linkedDataHub.json
Outdated
Show resolved
Hide resolved
src/main/resources/swagger.api/folio-modules/search/linkedDataHub.json
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/linked/data/integration/kafka/sender/search/HubCreateMessageSender.java
Outdated
Show resolved
Hide resolved
|
PBobylev
approved these changes
Oct 17, 2025
zepheiryan
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.