MODSOURCE-859: Fix Sonar issues

folio-org · Feb 21, 2025 · 4ac8c79 · 4ac8c79
1 parent 9d3509e
commit 4ac8c79
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/mod-source-record-storage-server/src/main/java/org/folio/services/RecordServiceImpl.java b/mod-source-record-storage-server/src/main/java/org/folio/services/RecordServiceImpl.java
@@ -427,11 +427,11 @@ public Future<Void> unDeleteRecordById(String id, IdType idType, Map<String, Str
     var tenantId = okapiHeaders.get(OKAPI_TENANT_HEADER);
     return recordDao.getRecordByExternalId(id, idType, tenantId)
       .map(recordOptional -> recordOptional.orElseThrow(() -> new NotFoundException(format(NOT_FOUND_MESSAGE, Record.class.getSimpleName(), id))))
-      .map(record -> {
-        update005field(record);
-        record.withState(Record.State.ACTUAL);
-        ParsedRecordDaoUtil.updateLeaderStatus(record.getParsedRecord(), CORRECTED_LEADER_RECORD_STATUS);
-        return record;
+      .map(foundRecord -> {
+        update005field(foundRecord);
+        foundRecord.withState(Record.State.ACTUAL);
+        ParsedRecordDaoUtil.updateLeaderStatus(foundRecord.getParsedRecord(), CORRECTED_LEADER_RECORD_STATUS);
+        return foundRecord;
       })
       .compose(record -> updateRecord(record, okapiHeaders)).map(r -> null);
   }

diff --git a/mod-source-record-storage-server/src/test/java/org/folio/services/RecordServiceTest.java b/mod-source-record-storage-server/src/test/java/org/folio/services/RecordServiceTest.java
@@ -1730,7 +1730,7 @@ public void shouldUnDeleteMarcRecord(TestContext context) {
       .withExternalIdsHolder(
         new ExternalIdsHolder()
           .withInstanceId(UUID.randomUUID().toString())
-          .withInstanceHrid(RandomStringUtils.randomAlphanumeric(9)))
+          .withInstanceHrid("12345abcd"))
       .withMetadata(marcBibMock.getMetadata());
 
     var okapiHeaders = Map.of(OKAPI_TENANT_HEADER, TENANT_ID);