Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODSOURCE-732] Change logic of DELETE record endpoint #596

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

RomanChernetskyi
Copy link
Contributor

@RomanChernetskyi RomanChernetskyi commented Feb 5, 2024

Purpose

Update delete records endpoint to properly delete records

Approach

Allow user to delete records by different idType using 'idType' query param (instanceId, matchedId, holdingsId, recordId, extermalId and authorityId) record id is default if no idType query param
Do the next step during the deletion of record:

  • Set 05 leader status to 'd'
  • set supressToDiscovery 'true'

@RomanChernetskyi RomanChernetskyi changed the title [MODSOURCE-732] [MODSOURCE-732] Change logic of DELETE record endpoint Feb 5, 2024
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@RomanChernetskyi RomanChernetskyi merged commit 18475c6 into master Feb 7, 2024
6 checks passed
@RomanChernetskyi RomanChernetskyi deleted the MODSOURCE-732 branch February 7, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants