depend on boolean for call

folio-org · Feb 21, 2025 · a2262c8 · a2262c8
1 parent b903d62
commit a2262c8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/DropdownMenu/DropdownMenu.js b/lib/DropdownMenu/DropdownMenu.js
@@ -1,4 +1,4 @@
-import React, { cloneElement, useRef } from 'react';
+import React, { cloneElement, useRef, useCallback } from 'react';
 import isBoolean from 'lodash/isBoolean';
 import noop from 'lodash/noop';
 import PropTypes from 'prop-types';
@@ -40,7 +40,8 @@ const DropdownMenu = ({ overrideStyle = {}, ...rest }) => {
   } = props;
 
   const ref = useRef(null);
-  useClickOutside(ref, open ? onToggle : noop);
+  const handleOutsideClick = useCallback((e, outside) => outside && onToggle(), [onToggle]);
+  useClickOutside(ref, open ? handleOutsideClick : noop);
 
   const renderChildren = () => {
     // don't pass along props that we didn't receive. if the