-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Popper documentation consistency #2197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider creating a Jira for this PR so we have way to document which release contains the auto-start
and auto-end
props.
Things might get interesting for this component when we look at migrating to floating-ui and its possibilities for placement... Will potentially mean even more docs changes, so if we want to hold on this, will be okay... |
@JohnC-80 IMO we should go ahead and merge this — the "new" placements are already accepted per the readme and supported by the code, just forgotten in the prop-types, so we're not adding something new |
|
There are several props available to the
Popper
component which were not documented in the README.Additionally, the placements
auto-start
andauto-end
were missing from theAVAILABLE_PLACEMENTS
array, despite being valid (looks like I missed these in #2004, whoops).