Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing InfoPopover props #2198

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Add missing InfoPopover props #2198

merged 3 commits into from
Jan 4, 2024

Conversation

ncovercash
Copy link
Member

The props buttonProps and popperProps are undocumented; this adds them to the README.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit b6aa50b. ± Comparison against base commit 629c639.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

BigTest Unit Test Statistics

       1 files  ±0         1 suites  ±0   11s ⏱️ ±0s
1 416 tests ±0  1 395 ✔️ ±0  21 💤 ±0  0 ❌ ±0 
1 419 runs  ±0  1 398 ✔️ ±0  21 💤 ±0  0 ❌ ±0 

Results for commit b6aa50b. ± Comparison against base commit 629c639.

♻️ This comment has been updated with latest results.

@ncovercash ncovercash mentioned this pull request Jan 4, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ncovercash ncovercash merged commit 99cfe5b into master Jan 4, 2024
5 checks passed
@ncovercash ncovercash deleted the add-missing-infopopover-props branch January 4, 2024 23:08
github-actions bot pushed a commit that referenced this pull request Jan 4, 2024
@ncovercash @JohnC-80
Add missing InfoPopover props (#2198)
ce3401f 
Co-authored-by: John Coburn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zburke zburke zburke approved these changes

@JohnC-80 JohnC-80 JohnC-80 approved these changes

@mweaver-ebsco mweaver-ebsco Awaiting requested review from mweaver-ebsco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncovercash @zburke @JohnC-80