Fix timepicker tests #2201
Merged
Fix timepicker tests #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JohnC-80
added a commit
that referenced
this pull request
Feb 28, 2024
(cherry picked from commit bffed23)
JohnC-80
added a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like moment got a bit more strict when handling single digit vs double digit parsing of time values, moment/moment#5592
Tests, in this case, were testing with a value that didn't exactly match the format anyhow, so they were a bit unrealistic to start with.
If this causes more grief than this, we might have to consider locking to moment v2.29.4 :/