Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-798 fully populate /bl-users/_self API response in tests #1401

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

zburke
Copy link
Member

@zburke zburke commented Jan 22, 2024

Provide a fully-populated user object, instead of an empty one, from /bl-users/_self in tests. Tests that expect an authenticated user may fail if they end up calling the endpoint and don't receive the expected data. It's unclear exactly why we're hitting this glitch now, but here we are. 🤷

h/t @JohnC-80 for figuring this out. He deserves the credit here; I'm just the codemonkey who happened to be available to implement his suggested fix.

Refs STCOR-798

Copy link

github-actions bot commented Jan 22, 2024

Jest Unit Test Statistics

137 tests  ±0   137 ✔️ ±0   23s ⏱️ -1s
  18 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 6ed08ae. ± Comparison against base commit 6fc8d5b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 22, 2024

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   10s ⏱️ ±0s
271 tests ±0  265 ✔️ ±0  6 💤 ±0  0 ±0 
274 runs  ±0  268 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit 6ed08ae. ± Comparison against base commit 6fc8d5b.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@zburke zburke marked this pull request as ready for review January 22, 2024 16:47
@zburke zburke changed the title test repair STCOR-798 fully populate /bl-users/_self API response in tests Jan 22, 2024
@zburke zburke requested review from JohnC-80 and a team January 22, 2024 16:55
@zburke zburke merged commit 811f7a4 into master Jan 22, 2024
6 checks passed
@zburke zburke deleted the test-repair branch January 22, 2024 18:34
@zburke zburke restored the test-repair branch January 22, 2024 20:09
@zburke zburke deleted the test-repair branch February 19, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants