Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-799 Upgrade/configure stylelint. #1403

Merged
merged 3 commits into from
Jan 26, 2024
Merged

STCOR-799 Upgrade/configure stylelint. #1403

merged 3 commits into from
Jan 26, 2024

Conversation

JohnC-80
Copy link
Contributor

@JohnC-80 JohnC-80 commented Jan 22, 2024

This PR copies the stylelint config from stripes-components to apply similar rules.

The changes, in a nutshell:

  • Using media-range notation for media queries
    • @media screen and (max-width: 440px) becomes @media screen and (width <= 440px)
  • Color function notation - remove commas, represent alpha with percentage proceeded by a slash.
    • rgba(0, 0, 0, 0.75) becomes rgba(0 0 0 / 75%).
  • Consolidating individual properties to single shorthand properties.
    • use inset: property and shorthand values as opposed to top, left, bottom, and right.
  • Some declaration re-arrangement due to descending specificity
    • .navButton::before being declared before .navButton would have to be switched.

Copy link

github-actions bot commented Jan 22, 2024

Jest Unit Test Statistics

137 tests  ±0   137 ✔️ ±0   24s ⏱️ -1s
  18 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit e7509c2. ± Comparison against base commit 592b1a0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 22, 2024

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   10s ⏱️ ±0s
271 tests ±0  265 ✔️ ±0  6 💤 ±0  0 ±0 
274 runs  ±0  268 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit e7509c2. ± Comparison against base commit 592b1a0.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

@JohnC-80 JohnC-80 requested review from zburke, a team and vashjs January 22, 2024 21:25
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JohnC-80 JohnC-80 merged commit f886643 into master Jan 26, 2024
6 checks passed
@JohnC-80 JohnC-80 deleted the STCOR-799 branch January 26, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants