Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-800 Show app/record when you have permission for that #1406

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

Dmitriy-Litvinenko
Copy link
Contributor

@Dmitriy-Litvinenko Dmitriy-Litvinenko commented Jan 24, 2024

Purpose

Show app/record when you have permission for that

Refs

https://issues.folio.org/browse/STCOR-800

Notes

Fix problem that user see error You don't have permission to view this app/record when have all necessary permission
We use comparison start with, but Mediated requests App (pathname requests-mediated) and Requests App (pathname requests) have pathname started from "requests". This mean that when we open Mediated requests application stripes-core think that we in Requests application and we do not have permission for Requests.

Copy link

github-actions bot commented Jan 24, 2024

Jest Unit Test Statistics

137 tests  ±0   137 ✔️ ±0   23s ⏱️ ±0s
  18 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 3597313. ± Comparison against base commit f886643.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 24, 2024

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   10s ⏱️ ±0s
271 tests ±0  265 ✔️ ±0  6 💤 ±0  0 ±0 
274 runs  ±0  268 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit 3597313. ± Comparison against base commit f886643.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

@Dmitriy-Litvinenko
Copy link
Contributor Author

Hello @zburke @JohnC-80 Could you please review?

@zburke zburke changed the title STCOR-800: Fix problem that user see error You don't have permission to view this app/record when have all necessary permission STCOR-800 match full module.route to find current module Jan 25, 2024
@zburke zburke changed the title STCOR-800 match full module.route to find current module STCOR-800 match module.route against full path segment to find current module Jan 25, 2024
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks great. Thank you!

Petty: Please describe the solution, not the problem, in PR titles/commit subjects and the CHANGELOG. Certainly it's helpful to describe the bug in the PR description as you do here, but the most important thing from the point of view of those short, one-line summaries is describing how the code changed, not a problem that is no longer present.

…to view this app/record when have all necessary permission
@Dmitriy-Litvinenko Dmitriy-Litvinenko changed the title STCOR-800 match module.route against full path segment to find current module STCOR-800 Show app/record when you have permission for that Jan 30, 2024
@Dmitriy-Litvinenko
Copy link
Contributor Author

Fix looks great. Thank you!

Petty: Please describe the solution, not the problem, in PR titles/commit subjects and the CHANGELOG. Certainly it's helpful to describe the bug in the PR description as you do here, but the most important thing from the point of view of those short, one-line summaries is describing how the code changed, not a problem that is no longer present.

Thank you. Fixed.

Copy link

@Dmitriy-Litvinenko Dmitriy-Litvinenko merged commit 18302ae into master Jan 30, 2024
6 checks passed
@Dmitriy-Litvinenko Dmitriy-Litvinenko deleted the STCOR-800 branch January 30, 2024 14:16
@zburke
Copy link
Member

zburke commented Jan 30, 2024

@Dmitriy-Litvinenko, please use "Squash and Merge" when merging a PR to keep the commit history clean and linear. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants