-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STCOR-800 Show app/record when you have permission for that #1406
Conversation
BigTest Unit Test Statistics 1 files ±0 1 suites ±0 10s ⏱️ ±0s Results for commit 3597313. ± Comparison against base commit f886643. This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix looks great. Thank you!
Petty: Please describe the solution, not the problem, in PR titles/commit subjects and the CHANGELOG. Certainly it's helpful to describe the bug in the PR description as you do here, but the most important thing from the point of view of those short, one-line summaries is describing how the code changed, not a problem that is no longer present.
…to view this app/record when have all necessary permission
c1ad241
to
3597313
Compare
Thank you. Fixed. |
|
@Dmitriy-Litvinenko, please use "Squash and Merge" when merging a PR to keep the commit history clean and linear. Thank you! |
Purpose
Show app/record when you have permission for that
Refs
https://issues.folio.org/browse/STCOR-800
Notes
Fix problem that user see error You don't have permission to view this app/record when have all necessary permission
We use comparison start with, but Mediated requests App (pathname requests-mediated) and Requests App (pathname requests) have pathname started from "requests". This mean that when we open Mediated requests application stripes-core think that we in Requests application and we do not have permission for Requests.