STCOR-801 Move async localforage.clear to afterEach

[JohnC-80]

The call to localForage.clear returns a promise, so it's best to handle it within an async call so that tests can wait for it. This seems to explain some difference we're seeing in timing between local test runs and CI such as the test runs from #1392

[github-actions]

Jest Unit Test Statistics

137 tests  ±0   137 ✔️ ±0   23s ⏱️ ±0s
  18 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 0d4e35b. ± Comparison against base commit fafd4f8.

♻️ This comment has been updated with latest results.

[github-actions]

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   10s ⏱️ ±0s
271 tests ±0  265 ✔️ ±0  6 💤 ±0  0 ❌ ±0 
274 runs  ±0  268 ✔️ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 0d4e35b. ± Comparison against base commit fafd4f8.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.

      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content

Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_120_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

[zburke]

Let's try it. Since afterEach can be properly async, maybe this is our ticket to real reliability. Nice sleuthing! 🕵️

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud