Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-949 omit leading slash in useModuleInfo's ky path #1599

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

zburke
Copy link
Member

@zburke zburke commented Feb 21, 2025

Whoops, ky doesn't want a leading slash when using the prefixUrl property and whines about it in the console.

Refs STCOR-949

Whoops, `ky` doesn't want a leading slash when using the `prefixUrl`
property and whines about it in the console.

Refs STCOR-949
@zburke zburke requested a review from vashjs February 21, 2025 11:42
@zburke zburke requested a review from a team as a code owner February 21, 2025 11:42
Copy link

github-actions bot commented Feb 21, 2025

Bigtest Unit Test Results

189 tests  ±0   184 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 07a9b39. ± Comparison against base commit db9d895.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_133_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
Chrome_133_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
Chrome_133_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_133_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_133_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 21, 2025

Jest Unit Test Results

  1 files  ±0   64 suites  ±0   1m 34s ⏱️ +2s
381 tests ±0  381 ✅ ±0  0 💤 ±0  0 ❌ ±0 
385 runs  ±0  385 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 07a9b39. ± Comparison against base commit db9d895.

♻️ This comment has been updated with latest results.

@zburke zburke merged commit 18b82a3 into master Feb 24, 2025
16 checks passed
@zburke zburke deleted the STCOR-949 branch February 24, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants