Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-950 Added location to a hook in <MainNav> to fix comparing old location value #1600

Merged
merged 2 commits into from
Feb 24, 2025
Merged

STCOR-950 Added location to a hook in <MainNav> to fix comparing old location value #1600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
805fb24
STCOR-950 Added `location` to a hook in `<MainNav>` to fix comparing …
BogdanDenis Feb 21, 2025
9f30da8
Merge branch 'master' into STCOR-950
BogdanDenis Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
* *BREAKING* replace useSecureTokens conditionalsRefs STCOR-922.
* Set tenant context based on authentication response with overrideUser parameter on login (Eureka, ECS - Single tenant UX) STCOR-946.
* Omit leading slash in paths passed to `ky` in `useModuleInfo`. Refs STCOR-949.
* Added `location` to a hook in `<MainNav>` to fix comparing old `location` value. Fixes STCOR-950.

## [10.2.0](https://github.com/folio-org/stripes-core/tree/v10.2.0) (2024-10-11)
[Full Changelog](https://github.com/folio-org/stripes-core/compare/v10.1.1...v10.2.0)
Expand Down
2 changes: 1 addition & 1 deletion src/components/MainNav/MainNav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ const MainNav = () => {
return () => {
_unsubscribe();
};
}, []); // eslint-disable-line
}, [location]); // eslint-disable-line

// if the location changes, we need to update the current module/query resource.
// This logic changes the visible current app at the starting side of the Main Navigation.
Expand Down