-
Notifications
You must be signed in to change notification settings - Fork 26
250407 reduce test noise #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
250407 reduce test noise #1618
Conversation
Bigtest Unit Test Results189 tests ±0 184 ✅ ±0 7s ⏱️ -1s Results for commit b16a2c2. ± Comparison against base commit 165587c. This pull request removes 191 and adds 189 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 5 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
zburke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, BRING THE NOISE!!!
Alternatively, we could resolve the react-intl complaints by updating package.json like
"test:bigtest": "stripes translate compile && stripes test karma",
|
|
@JohnC-80 , another alternative to tweaking console: use stripes-config to tell stripes-core to tell react-intl to STFU by setting |



This PR fixes one potentially flakey test by removing a 404 on an image from some static JSON that was included with the test suite. I moved the static JSON into the test file and imported the
svgas similar tests forAppIcondo...Additionally, added a bit to
setupApplicationto suppress the console noise warnings from[@formatjs/intl]about compiling translations that happen any time a<FormattedMessage>renders. Leaving some other console messages in there - i.e. Mirage messages about the app trying to access unhandled endpoints.