Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix recover step for NodeSelectorChaos #100

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

mikolaj-krzyzanowski-f3
Copy link

@mikolaj-krzyzanowski-f3 mikolaj-krzyzanowski-f3 commented Jan 14, 2025

What problem does this PR solve?

Currently, the recovery step might remove the annotation too early. It will be a no-op and a cleanup step will be used instead. To this end, the value is now optional.

What's changed and how it works?

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test
chaos.yml
---
apiVersion: chaos-mesh.org/v1alpha1
kind: Schedule
metadata:
  name: az-loss
spec:
  schedule: '0/5 * * * *' 
  historyLimit: 1
  concurrencyPolicy: 'Forbid'
  startingDeadlineSeconds: 1
  type: 'Workflow'
  workflow:
    entry: az-loss-workflow-entry
    templates:
      - name: az-loss-workflow-entry
        templateType: Serial
        deadline: 5m
        children:
          - eu-west-2a-az-chaos-20m
          - eu-west-2a-az-chaos-default
      - name: eu-west-2a-az-chaos-20m
        templateType: NodeSelectorChaos
        deadline: 3m
        nodeselectorChaos:
          value: eu-west-2a
          key: topology.kubernetes.io/zone
          selector:
            deployments:
              nats-eks:
                - nats-box
      - name: eu-west-2a-az-chaos-default
        templateType: NodeSelectorChaos
        deadline: 2m
        nodeselectorChaos:
          key: topology.kubernetes.io/zone
          selector:
            deployments:
              nats-eks:
                - nats-box

Observed same results as #99, except after running a cleanup step above rather than recovery.

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@mikolaj-krzyzanowski-f3 mikolaj-krzyzanowski-f3 requested a review from a team as a code owner January 14, 2025 12:09
Copy link

Created new release based on commit aba2f6b

Release tag: v2.6.1-f3-aba2f-quinnh-no-recover

Link to release

Copy link

Created new release based on commit da139d6

Release tag: v2.6.1-f3-da139-quinnh-no-recover

Link to release

Copy link

Created new release based on commit b457550

Release tag: v2.6.1-f3-b4575-quinnh-no-recover

Link to release

@mikolaj-krzyzanowski-f3 mikolaj-krzyzanowski-f3 merged commit 3ee7232 into master Jan 14, 2025
47 checks passed
@mikolaj-krzyzanowski-f3 mikolaj-krzyzanowski-f3 deleted the quinnh-no-recover branch January 14, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants