Conversation
nvloff-f3
force-pushed
the
nvloff-user-logger
branch
from
36d5fcc to
6367340
Compare
mlornac
approved these changes
Jul 11, 2024
nvloff-f3
force-pushed
the
nvloff-user-logger
branch
from
6367340 to
94941ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The built in logger, especially the JSON formater is very opinionated about the syntax and the fields to align with logrus behavior within the Form3 domain (such as
@timestampfield name and the time formatting for it, etc.)While we want to keep the defaults for ease of use, allow users to specify their own logger to align with their organizational ecosystem.