Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server start and delete interactions order #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcin-piwowarczyk-form3

While running mock services api using IntegrationTest we have noticed errors in logs output caused by failed call to pact api with delete interactions request.

While investigating the root cause I noticed, the TestWithStubServices function is calling api endpoint using DeleteInteractions function before pact api server is started, causing connection errors.

Usually it's not causing any problems expect the errors in logs because we are removing interactions again in defer operation, anyway it's making noise in logs.

proxying request: Delete \"http://127.0.0.1:56983/interactions\": dial tcp 127.0.0.1:56983: connect: connection refused
proxying request: Delete \"http://127.0.0.1:56984/interactions\": dial tcp 127.0.0.1:56984: connect: connection refused

Changing order of the operations in the way we are starting pact server before deleting interactions is solving the issue.

@marcin-piwowarczyk-form3 marcin-piwowarczyk-form3 requested a review from a team as a code owner November 4, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants