fix: fix loading values from source last req #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-drzymala-form3
force-pushed
the
md-fix-load-values
branch
from
304eab1 to
72991ef
Compare
This will fix a problem with fetching the values from the source interaction last request. The problem occurs when the values from the source interaction are being used as a constraint. Due to the bug the json path library is unable to fetch the specified values from the source last request document.
mlornac
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix a problem with fetching the values from the source interaction last request. The problem occurs when the values from the source interaction are being used as a constraint. Due to the bug the json path library is unable to fetch the specified values from the source last request document.
Proof of Work
The unit tests for
loadValuesFromSourcefunction fails without the fix : https://github.com/form3tech-oss/pact-proxy/actions/runs/12708671770/job/35426099780After adding the fix the CI is green 🟢