Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize Fortran Package Manager as proper noun #29

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Dec 15, 2021

  • rebuild all po-files, they are not really whitespace stable unfortunately

Preview deployed to https://awvwgk.github.io/fpm-docs/

@awvwgk awvwgk force-pushed the fortran-package-manager branch from 3a3a1ca to 090447c Compare December 15, 2021 23:31
@aslozada
Copy link
Member

aslozada commented Dec 16, 2021

If the term "Fortran Package Manager" is a proper noun, should it be translated?

@awvwgk
Copy link
Member Author

awvwgk commented Dec 16, 2021

Good question. I would still translate it.

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

I don't know how these .po files work. What's a good reference?

@awvwgk
Copy link
Member Author

awvwgk commented Dec 16, 2021

I don't know how these .po files work. What's a good reference?

I collected a few references in #5

@awvwgk
Copy link
Member Author

awvwgk commented Dec 18, 2021

Will go ahead and merge.

@awvwgk awvwgk merged commit 99a8ddd into fortran-lang:main Dec 18, 2021
@awvwgk awvwgk deleted the fortran-package-manager branch December 18, 2021 10:55
@aslozada
Copy link
Member

Some sections that have already been translated are back in English.

cn:
11
de:
12
es:
13

@awvwgk
Copy link
Member Author

awvwgk commented Dec 18, 2021

This would be related to the change in #27 and here, which reworded most text on the main page. You can find those mismatched translations in the po file with a fuzzy attribute:

#: ../../pages/index.md:19
#, fuzzy
msgid ""
"Welcome to the documentation for the Fortran Package Manager (fpm). This "
"documentation is divided in four parts. Select one of the topics below to"
" continue."
msgstr ""
"Bienvenido a la documentación del Administrador de paquetes de Fortran "
"(fpm). Esta documentación está dividida en cuatro partes principales, "
"seleccione uno de los tópicos abajo para continuar."

Text that was reworded in a way that it doesn't match anymore for the translation will be commented out rather than removed:

#~ msgid ""
#~ "Specifications of the components of the"
#~ " Fortran package manager and references "
#~ "for the actual implementation."
#~ msgstr ""
#~ "Especificación de los componentes del "
#~ "Adminstrador de paquetes de Fortran y"
#~ " referencias para la implementación real."

@awvwgk
Copy link
Member Author

awvwgk commented Dec 18, 2021

I'll do a cleanup of the translation for the minor changes. I'll leave the other changes in as fuzzy, those require some review by you, even if the translations will most likely match alright. Feel free to push changes to #32.

@aslozada
Copy link
Member

Conflicts with my fork. I'm a little confused.
"Open a pull request to fetch upstream and review changes or resolve conflicts."

@awvwgk
Copy link
Member Author

awvwgk commented Dec 18, 2021

Best to not work on the main branch, you can fix this up with:

git checkout main
git fetch [email protected]:fortran-lang/fpm-docs
git reset --hard FETCH_HEAD
git push --force [email protected]:aslozada/fpm-docs main

@aslozada
Copy link
Member

Sebastian @awvwgk: Thanks very much. The upstream (fetch) was in awvwgk/fpm-docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants