add git dependencies with submodules#816
Open
freevryheid wants to merge 2 commits intofortran-lang:mainfrom
Open
add git dependencies with submodules#816freevryheid wants to merge 2 commits intofortran-lang:mainfrom
freevryheid wants to merge 2 commits intofortran-lang:mainfrom
Conversation
awvwgk
requested changes
Feb 4, 2023
Member
awvwgk
left a comment
awvwgk
left a comment
There was a problem hiding this comment.
I don't think that will reliable work in case we update a dependency. Also, I'm unhappy with the directory change, it would be much preferable to do this in the working directory and just pass the paths as we do for other git commands.
Contributor
Author
|
Could it be as simple as this? Tests OK on repos with submodules. |
Contributor
|
@awvwgk what is your verdict on this? Merge or close? |
Contributor
|
@krystophny @freevryheid @awvwgk I'm contributing a git submodule to a project and would like to see this merged before bit rot sets in. Given the length of time that this has existed, would anyone object to merging it as is and creating a new issue that capture's @awvwgk's suggested change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cannot figure howto achieve this without cd'ing into the directory