Skip to content

Add NCKU_Vending_Machine #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add NCKU_Vending_Machine #19

wants to merge 6 commits into from

Conversation

cstandy
Copy link

@cstandy cstandy commented Jul 9, 2018

ARC Contest 2018 Taiwan Team 5 Vending Machine

  • Topic: Vending Machine With Cloud Management And Smart Selling System
  • Team number: 5
  • University: National Cheng Kung University

User Manual

Please check embarc_applications/arc_design_contest/2018/vending_machine/README.md

@cstandy cstandy closed this Jul 9, 2018
@cstandy cstandy reopened this Jul 9, 2018
@YuguoWH YuguoWH self-requested a review July 11, 2018 02:16
@YuguoWH YuguoWH changed the title pull request for ARC Contest 2018 Team 5 Add NCKU_Vending_Machine Jul 11, 2018
YuguoWH
YuguoWH suggested changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@YuguoWH YuguoWH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request exceed 10MB size, please trim your files. If your have too many pictures or documents, upload them online and provide link in your readme.
Please do NOT upload embarc_osp files. Thanks.

@cstandy
Copy link
Author

cstandy commented Jul 11, 2018

Upload the document to the Google Drive.
The total size is 512 kB now.
NOTE the file in the folder embarc_osp-master in this request ONLY contains the files which has been modified for this application. The file folder hierarchy in embarc_osp-master is the same as the original one, so it will be easier to understand the path of the modified files.

YuguoWH
YuguoWH suggested changes Jul 12, 2018
View reviewed changes
arc_design_contest/2018/NCKU_Vending_Machine/embarc_osp-master/board/board.c

/* create 5 tasks */
xTaskCreate((TaskFunction_t)vm_task, "vending machine", TASK_STACK_SIZE_VM, NULL, TASK_PRI_VM, &task_handle_vm);
xTaskCreate((TaskFunction_t)LED_task, "led blinky", TASK_STACK_SIZE_LED, NULL, TASK_PRI_LED, &task_handle_led);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not accept modification to board.c to create user taskes.
@fanghuaqi This PR is also unable to pass CI, please take a look. THX.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, @cstandy you need to create tasks in your application code not in embARC OSP code, and could you make a list of the changes in diff or send a pull request to embarc_osp, that you have made to embARC OSP, let us see what can be modified and added in application code not osp code.

@IRISZZW IRISZZW force-pushed the master branch 3 times, most recently from 2e2a77e to 8836b6d Compare October 29, 2020 11:15
@wangnuannuan wangnuannuan force-pushed the master branch 2 times, most recently from cd69f67 to bd0efa1 Compare April 21, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanghuaqi fanghuaqi fanghuaqi left review comments

@YuguoWH YuguoWH YuguoWH requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstandy @fanghuaqi @YuguoWH