Skip to content

Zephyr-embARC_MLI internal review #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: siyuan-embarc_mli_v2.0-base_tempo
Choose a base branch
from

Conversation

SiyuanCheng-CN
Copy link

No description provided.

@ruuddw
Copy link
Member

ruuddw commented Jun 23, 2022

Thanks, I'll have a closer look later. Quick feedback: for the earlier PR, Zephyr TSC feedback was that they did not like pulling in another MPI copy/module as there already is one. Could you do a comparison between these? Would it e.g. be feasible to merge the ARC MLI changes into that one, or are they too different?

@SiyuanCheng-CN
Copy link
Author

SiyuanCheng-CN commented Jun 24, 2022

In my understanding, what the TSC said for another ML module is Tensorflow. In Tensorflow, other than generic ML code, it also has some platform-specific library, including embARC_MLI to accelerate some part of kernel functions.
From what I can see now:

  1. The version of embARC_MLI in Tensorflow is v1.1, now the latest version is v2.0. Difference between them is big.
  2. embARC_MLI now support plenty of networks, example in Tensorflow only accelerate one network.
  3. Example in Tensorflow only targets emsdp.
  4. Seems like example can only run in Tensorflow, not in Zephyr.

For context switch, it only support non-preemptive switching, without adding DSP registers, it also work. If you want me to add DSP registers in callee-saved register, I can help.

Siyuan Cheng added 6 commits July 4, 2022 14:18
Add arc XY mem configuration

Signed-off-by: Siyuan Cheng <[email protected]>
Add embarc_mli_v2.0 module and linker script

Signed-off-by: Siyuan Cheng <[email protected]>
add hello_world example to mli module

Signed-off-by: Siyuan Cheng <[email protected]>
add cifar10 example to mli module

Signed-off-by: Siyuan Cheng <[email protected]>
add har example to mli module

Signed-off-by: Siyuan Cheng <[email protected]>
code style update

Signed-off-by: Siyuan Cheng <[email protected]>
@SiyuanCheng-CN SiyuanCheng-CN force-pushed the siyuan-embarc_mli_v2.0 branch from 0055daf to 8d848b2 Compare July 4, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants