Added Show/Hide password in signup page#447
Open
rajvaibhavdubey wants to merge 1 commit intofossasia:masterfrom
Open
Added Show/Hide password in signup page#447rajvaibhavdubey wants to merge 1 commit intofossasia:masterfrom
rajvaibhavdubey wants to merge 1 commit intofossasia:masterfrom
Conversation
Adds show/hide password button on signup page. Fixes fossasia#445
neeraj3029
approved these changes
Nov 5, 2018
samagragupta
reviewed
Nov 6, 2018
| toggle.classList.toggle("fa-eye"); | ||
| toggle.classList.toggle("fa-eye-slash"); | ||
| if (toggle.classList.contains("fa-eye-slash")) { | ||
| document.getElementById("password").type = "password"; |
Member
There was a problem hiding this comment.
Instead of document.getElementById("password") you can use password
the-codingninja
requested changes
Dec 6, 2018
Member
the-codingninja
left a comment
the-codingninja
left a comment
There was a problem hiding this comment.
Please do the suggested changes
yashasvi128
approved these changes
Dec 8, 2018
samagragupta
suggested changes
Dec 15, 2018
Member
samagragupta
left a comment
samagragupta
left a comment
There was a problem hiding this comment.
Please do the following changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #445
Checklist
masterbranch.Short description of what this resolves:
Adds show/hide password button on signup page.