Fix-408 Using materialistic alerts#495
Open
championpaddler wants to merge 2 commits intofossasia:masterfrom
Open
Fix-408 Using materialistic alerts#495championpaddler wants to merge 2 commits intofossasia:masterfrom
championpaddler wants to merge 2 commits intofossasia:masterfrom
Conversation
Member
Author
|
@fossasia/susi-ai @mariobehling Please review. |
abishekvashok
suggested changes
Dec 6, 2018
championpaddler
force-pushed
the
Fix-408
branch
from
8311be9 to
3c0f4de
Compare
Member
Author
|
@zamhaq Please review. |
Member
Author
|
@mariobehling @ms10398 @fossasia/susi-ai Please review |
Member
Author
|
@hkedia321 @techpool Please approve. |
Member
Author
|
@zamhaq Please review and merge this. |
Member
Author
fragm3
requested changes
Jan 22, 2019
Contributor
fragm3
left a comment
fragm3
left a comment
There was a problem hiding this comment.
Please see inline review @sk9331657
src/js/options.js
Outdated
| }, (stream) => { | ||
| stream.getTracks().forEach(track => track.stop()); | ||
| displayNotification("success", " Mic Access Granted", 1000); | ||
|
|
src/js/options.js
Outdated
| }, () => { | ||
| console.log("no access"); | ||
| displayNotification("error", " No Access", 1000); | ||
|
|
src/js/options.js
Outdated
| displayNotification("error", " No Access", 1000); | ||
|
|
||
| }); | ||
|
|
src/js/options.js
Outdated
| localStorage.setItem("theme",theme); | ||
| alert("Success"); | ||
| }); | ||
| displayNotification("info", "Theme successfully changed", 1000); |
src/js/options.js
Outdated
|
|
||
| }); | ||
| displayNotification("warning", " Restored Settings", 1000); | ||
|
|
championpaddler
force-pushed
the
Fix-408
branch
3 times, most recently
from
0c22512 to
1b5812e
Compare
championpaddler
force-pushed
the
Fix-408
branch
from
1b5812e to
6ef0536
Compare
Member
Author
|
@fragm3 Resolved Issues. |
neeraj3029
approved these changes
Jan 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #408
Checklist
masterbranch.Short description of what this resolves:
Changes proposed in this pull request:
-Using materialistic alerts.