Added eye feature in change password form#500
Open
samagragupta wants to merge 1 commit intofossasia:masterfrom
Open
Added eye feature in change password form#500samagragupta wants to merge 1 commit intofossasia:masterfrom
samagragupta wants to merge 1 commit intofossasia:masterfrom
Conversation
rupav
reviewed
Dec 8, 2018
Member
rupav
left a comment
rupav
left a comment
There was a problem hiding this comment.
Can you please add some gifs to show the working of it?
Member
Author
|
@rupav Uploaded the gif |
Member
Author
|
@gabru-md @hkedia321 Please review. |
hkedia321
approved these changes
Jan 7, 2019
fragm3
requested changes
Jan 22, 2019
Contributor
fragm3
left a comment
fragm3
left a comment
There was a problem hiding this comment.
Instead of using 3 addEventListener, create a function to do so
Member
Author
|
@fragm3 There is no need of a function as there would event Listener for every eye. |
fragm3
requested changes
Jan 24, 2019
Contributor
fragm3
left a comment
fragm3
left a comment
There was a problem hiding this comment.
@samagragupta you can simply loop over an array to achieve the same thing. Look into this
Member
Author
|
@ms10398 @hkedia321 Please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #466
Checklist
masterbranch.Short description of what this resolves:
Changes proposed in this pull request:
Added eye in the password fields