Skip to content

Padding added#509

Open
plxity wants to merge 1 commit intofossasia:masterfrom
plxity:master
Open

Padding added#509
plxity wants to merge 1 commit intofossasia:masterfrom
plxity:master

Conversation

@plxity
Copy link
Member

@plxity plxity commented Dec 21, 2018

Fixes #507

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Padding is added in the message displayed when clicked on mic button

Changes proposed in this pull request:

  • Padding added

Copy link
Member

@the-codingninja the-codingninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis and Codacy is failing becuase of mixed quotes please fix that you can test locally by jshint once before pushing

@plxity
Copy link
Member Author

plxity commented Dec 22, 2018

@ms10398 Thank you for the help. I have done the changes. Please review.

@fossasia fossasia deleted a comment Dec 22, 2018
@fossasia fossasia deleted a comment from plxity Dec 22, 2018
@fossasia fossasia deleted a comment from the-codingninja Dec 22, 2018
@plxity
Copy link
Member Author

plxity commented Dec 23, 2018

@ms10398 Please review this.

Copy link
Member

@AdityaSrivast AdityaSrivast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plxity Please stash your commits

changes

Update script.js
@plxity
Copy link
Member Author

plxity commented Jan 3, 2019

@ms10398 @zamhaq Please review this.

Copy link
Contributor

@fragm3 fragm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill the commit message, title, add screenshot(always if it's UI change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No padding present

4 participants