Alerting "success" only when some option is selected and submit is clicked in settings#525
Open
Puranjay25 wants to merge 7 commits intofossasia:masterfrom
Open
Alerting "success" only when some option is selected and submit is clicked in settings#525Puranjay25 wants to merge 7 commits intofossasia:masterfrom
Puranjay25 wants to merge 7 commits intofossasia:masterfrom
Conversation
Member
samagragupta
left a comment
There was a problem hiding this comment.
Please fill the details in the PR description.
Also, provide a GIF or Image.
Author
|
@samagragupta I have filled the details in PR description |
Member
samagragupta
left a comment
There was a problem hiding this comment.
Please use a more descriptive class name.
Rest looks good.
Author
|
@samagragupta I have changed the class name |
fragm3
requested changes
Jan 22, 2019
Contributor
fragm3
left a comment
There was a problem hiding this comment.
Please fill the issue number. Use descriptive variable names, indent the code properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Checklist
masterbranch.Short description of what this resolves:
Previously in settings page when user clicks Submit button without actually changing the Message Pane Colour or Predefined themes it shows a success message.
But now success message will only be displayed when some different colour or theme is selected.
Changes proposed in this pull request: