updating archiving source codes with -e option #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs to get review. |
|
@heedu , 수정한 내용이 무엇인지 Description 에 작성 부탁드립니다. |
|
@soimkim |
soimkim
requested changes
Jan 9, 2025
Comment on lines
188
to
189
| # for 'e' option to compress fetched files. | ||
| oss_item['source_done'] = item['complete'] |
src/fosslight_yocto/_package_item.py
Outdated
| @@ -42,6 +42,8 @@ def __init__(self): | |||
| self.additional_data = {} | |||
| self.pv = "" | |||
| self.pr = "" | |||
There was a problem hiding this comment.
추가된 변수는 하위로 이동해주시고 e옵션용 변수로 주석 달고, 각각에 대한 설명을 변수 옆 주석으로도 추가해주십시오.
|
@heedu , build 에러 확인 부탁드리며, |
|
-e 옵션으로 소스 압축시, output 결과물도 포함되어서 이를 제외시키고자 build time 시간 이후에 생성된 파일은 취합하지 않는 변경사항으로 확인합니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add new field in bom.json "complete" to check source code fetch done.
It needs to remove build output because yocto build system use same repository in recipe output path in "S" variable.
it will be used to archive source codes by fetching only source codes in source code location in bom.json.
Also, if source reference in recipe only indicates file path, fosslight yocto will only archive each source codes by ignoring
build output.
Type of change