Restore multicore build support with kernel-bootstrap #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Googulator
force-pushed
the
kernel-bootstrap-jobs
branch
from
8d994c2 to
42e71bf
Compare
stikonas
approved these changes
Jan 1, 2024
fosslinux
reviewed
Jan 2, 2024
Googulator
force-pushed
the
kernel-bootstrap-jobs
branch
from
42e71bf to
7101b3b
Compare
|
I settled for finalize_job_count in the end. |
fosslinux
approved these changes
Jan 8, 2024
|
ergh, conflicts... |
Perform variable substitution at runtime, rather than at generation time. This way, if bootstrap.cfg changes after update_env, the new values there take effect immediately.
This was removed as part of the simplify refactor, severely slowing down qemu and bare-metal builds. Restoring it brings us back to the same build times that we saw before the refactor.
Googulator
force-pushed
the
kernel-bootstrap-jobs
branch
from
7101b3b to
50d1d68
Compare
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed as part of the simplify refactor, severely slowing down qemu and bare-metal builds. Restoring it brings us back to the same build times that we saw before the refactor.