Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build/test condition on workflow and set v1.2.6 #229

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sunya-ch
Copy link
Collaborator

This PR contains two commits:

  1. correct the build condition to main branch and the test condition to all PRs
  2. execute VERSION=1.2.6 make set_version

Signed-off-by: Sunyanan Choochotkaew <[email protected]>
Signed-off-by: Sunyanan Choochotkaew <[email protected]>
@minmzzhang
Copy link
Collaborator

Hi @sunya-ch , if we want to build on main instead of individual release, we don't need the following line in Makefile:

    @$(SED_CMD) -i '0,/branches:/s//branches:/; n; s/- v.*/- v$(VERSION)/' .github/workflows/*.yaml

@sunya-ch
Copy link
Collaborator Author

Hi @sunya-ch , if we want to build on main instead of individual release, we don't need the following line in Makefile:

    @$(SED_CMD) -i '0,/branches:/s//branches:/; n; s/- v.*/- v$(VERSION)/' .github/workflows/*.yaml

Thank you. I have removed the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants