Skip to content

fix(chisel): handle empty run() function execution gracefully #12933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
forkfury wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(chisel): handle empty run() function execution gracefully #12933

forkfury wants to merge 2 commits into from
+13 −1

Conversation

@forkfury
Copy link
Contributor

@forkfury forkfury commented Dec 26, 2025

Fixes #12924

Changed SessionSource::execute() to return success when final_pc is None (empty run() function), instead of failing with "Failed to execute edited contract!" error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Foundry
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chisel throws Error: Failed to execute edited contract!

1 participant

@forkfury