Skip to content

Refactor gas resources logic#4083

Merged
DelevoXDG merged 6 commits intomasterfrom
zdobnikau/refactor-resources-for-gas-calculations
Jan 16, 2026
Merged

Refactor gas resources logic#4083
DelevoXDG merged 6 commits intomasterfrom
zdobnikau/refactor-resources-for-gas-calculations

Conversation

@DelevoXDG
Copy link
Copy Markdown
Contributor

@DelevoXDG DelevoXDG commented Jan 9, 2026

Stack

Introduced changes

Add common GasCalculationResources that is used both for calculations and displaying resources in --detailed-resources output. This will make it easier to track the affected resources and avoid missing the any resources in output.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@DelevoXDG DelevoXDG changed the title [wip] refactor gas resources logic Refactor gas resources logic Jan 13, 2026
@DelevoXDG DelevoXDG force-pushed the zdobnikau/refactor-resources-for-gas-calculations branch from c7ecd9e to cfa010e Compare January 13, 2026 17:20
@DelevoXDG DelevoXDG marked this pull request as ready for review January 14, 2026 09:23
@DelevoXDG DelevoXDG requested review from a team, MKowalski8 and ksew1 January 14, 2026 09:23
Copy link
Copy Markdown
Contributor

@MKowalski8 MKowalski8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread crates/forge-runner/src/gas/resources.rs
@ddoktorski ddoktorski requested review from ddoktorski and removed request for ksew1 January 15, 2026 13:01
@DelevoXDG DelevoXDG force-pushed the zdobnikau/refactor-resources-for-gas-calculations branch from cfa010e to b0cddbf Compare January 16, 2026 14:04
@DelevoXDG
Copy link
Copy Markdown
Contributor Author

I sent the re-review request mistakenly, meant to do so for the subsequent PR 😅

@DelevoXDG DelevoXDG added this pull request to the merge queue Jan 16, 2026
Merged via the queue into master with commit 816ed3d Jan 16, 2026
32 checks passed
@DelevoXDG DelevoXDG deleted the zdobnikau/refactor-resources-for-gas-calculations branch January 16, 2026 16:56
github-merge-queue Bot pushed a commit that referenced this pull request Jan 20, 2026
…4092)

<!-- Reference any GitHub issues resolved by this PR -->

Closes #3828

## Stack
- #4083 
- #4092

## Introduced changes

<!-- A brief description of the changes -->

- Add remaining gas-related resources to `--detailed-resources`:
  - events
  - messages

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants