Skip to content

Align sncast err handling; Add alisases sncast get transaction, sncast get transaction-status #4223

Open
DelevoXDG wants to merge 8 commits intomasterfrom
zdobnikau/sncast-fixes
Open

Align sncast err handling; Add alisases sncast get transaction, sncast get transaction-status #4223
DelevoXDG wants to merge 8 commits intomasterfrom
zdobnikau/sncast-fixes

Conversation

@DelevoXDG
Copy link
Copy Markdown
Contributor

@DelevoXDG DelevoXDG commented Mar 19, 2026

Towards #4144
Towards #4184

Stack

Introduced changes

  • Align sncast err handling
  • Add alisases sncast get transaction, sncast get transaction-status

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@DelevoXDG DelevoXDG marked this pull request as ready for review March 19, 2026 16:04
@DelevoXDG DelevoXDG requested a review from a team as a code owner March 19, 2026 16:04
@DelevoXDG DelevoXDG requested review from MKowalski8 and franciszekjob and removed request for a team March 19, 2026 16:04
github-merge-queue bot pushed a commit that referenced this pull request Apr 8, 2026
<!-- Reference any GitHub issues resolved by this PR -->

Towards #4144

## Stack
- #4215 
- #4210
- #4218 
- #4217 
- #4219
- #4220
- #4223
- #4224


## Introduced changes

<!-- A brief description of the changes -->

-

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
github-merge-queue bot pushed a commit that referenced this pull request Apr 8, 2026
<!-- Reference any GitHub issues resolved by this PR -->

Towards #4144

## Stack
- #4215 
- #4210
- #4218 
- #4217 
- #4219
- #4220
- #4223
- #4224


## Introduced changes

<!-- A brief description of the changes -->

- add `sncast utils selector`

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
@DelevoXDG DelevoXDG force-pushed the zdobnikau/sncast-class-hash-at branch from 3604996 to 4a6bdb7 Compare April 8, 2026 13:56
github-merge-queue bot pushed a commit that referenced this pull request Apr 8, 2026
<!-- Reference any GitHub issues resolved by this PR -->

Towards #4144

## Stack
- #4215 
- #4210
- #4218 
- #4217 
- #4219
- #4220
- #4223
- #4224

## Introduced changes

<!-- A brief description of the changes -->

- Add `sncast get class-hash-at`

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Franciszek Job <54181625+franciszekjob@users.noreply.github.com>
Base automatically changed from zdobnikau/sncast-class-hash-at to master April 8, 2026 15:22
@DelevoXDG DelevoXDG force-pushed the zdobnikau/sncast-fixes branch 2 times, most recently from 4a0db97 to 67b7052 Compare April 13, 2026 10:03
Comment thread crates/sncast/src/starknet_commands/get/mod.rs
Comment thread crates/sncast/src/starknet_commands/get/transaction.rs
Comment thread crates/sncast/src/starknet_commands/get/mod.rs
@DelevoXDG DelevoXDG requested a review from MKowalski8 April 16, 2026 08:44
@DelevoXDG DelevoXDG force-pushed the zdobnikau/sncast-fixes branch from 924197d to 76e4b41 Compare April 16, 2026 10:44
- properly pass results to `process_command_result` (towards #4184)
- avoid adding unnecessary `context`
Switch get_tx_status to anyhow::Result and remove redundant error remapping in tx_status so command handling matches get tx flow.
attempt `test_tx_status_incorrect_transaction_hash` fix
@DelevoXDG DelevoXDG force-pushed the zdobnikau/sncast-fixes branch from 17adca2 to a56105e Compare April 17, 2026 14:16
@DelevoXDG DelevoXDG enabled auto-merge April 17, 2026 14:23
@DelevoXDG DelevoXDG added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants