Skip to content

Remove unneded feature flags in tests#4295

Draft
MKowalski8 wants to merge 1 commit intomasterfrom
mkowalski/remove-unused-features-flags
Draft

Remove unneded feature flags in tests#4295
MKowalski8 wants to merge 1 commit intomasterfrom
mkowalski/remove-unused-features-flags

Conversation

@MKowalski8
Copy link
Copy Markdown
Member

@MKowalski8 MKowalski8 commented Apr 20, 2026

Towards #4091

Introduced changes

  • Delete unneded feature flags and unify oracles tests in normal e2e

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@MKowalski8 MKowalski8 changed the title Delete unneded feature flags in tests Remove unneded feature flags in tests Apr 20, 2026
else
FEATURES="skip_test_for_only_latest_scarb"
fi
FEATURES="skip_test_for_only_latest_scarb"
Copy link
Copy Markdown
Member

@piotmag769 piotmag769 Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this flag while we are at it - I spent 10 minutes today wondering if it should skip tests while Scarb is latest or if it should skip them for non-latest xD

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I can do that. I'm cleaning those features a little bit 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants