Optimize config resolution for non-matching targets in --exact runs#4296
Open
franciszekjob wants to merge 18 commits intomasterfrom
Open
Optimize config resolution for non-matching targets in --exact runs#4296franciszekjob wants to merge 18 commits intomasterfrom
--exact runs#4296franciszekjob wants to merge 18 commits intomasterfrom
Conversation
…tion-with-exact-flag
…ct-flag' of https://github.com/foundry-rs/starknet-foundry into franciszekjob/3899-optimize-configs-resolution-with-exact-flag
franciszekjob
commented
Apr 22, 2026
Comment on lines
-41
to
-44
| let casm_program = Arc::new(compile_raw_sierra_at_path( | ||
| test_target_raw.sierra_program_path.as_std_path(), | ||
| )?); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
note: Compilation was moved below so it happens only if there are tests to be run from a test target.
--exact runs--exact runs
franciszekjob
commented
Apr 23, 2026
Comment on lines
+23
to
+27
| #[derive(Debug, Clone, Copy)] | ||
| pub enum TestNameSelection<'a> { | ||
| All, | ||
| ExactMatch(&'a str), | ||
| } |
Contributor
Author
There was a problem hiding this comment.
note: We can extend it later so the optimization will work with test name filter too. However, this will be related with the number of filtered out tests, which is displayed. For --exact we simply display other filtered out while for matching name filter, we actually count them.
MKowalski8
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3899
Introduced changes
Skip config resolution for non-matching targets when
--exactflag is used. This change is helpful for test run code lens in LS, since they use--exact.With
--workspaceflagBefore
After
With
--packageflagBefore
After
(Benches done in comparison with snforge
nightly-2026-04-22)Checklist
CHANGELOG.md