Remove check for SCARB_WITHOUT_CAIRO_TEST_TEMPLATE#4304
Draft
MKowalski8 wants to merge 9 commits intomkowalski/remove-unused-features-flagsfrom
Draft
Remove check for SCARB_WITHOUT_CAIRO_TEST_TEMPLATE#4304MKowalski8 wants to merge 9 commits intomkowalski/remove-unused-features-flagsfrom
SCARB_WITHOUT_CAIRO_TEST_TEMPLATE#4304MKowalski8 wants to merge 9 commits intomkowalski/remove-unused-features-flagsfrom
Conversation
MKowalski8
force-pushed
the
mkowalski/3910-delete-check-for-ciaro-test-template
branch
2 times, most recently
from
e99b3d4 to
cb88c35
Compare
MKowalski8
commented
Apr 23, 2026
| format!( | ||
| "❌ {} Version {} doesn't satisfy minimal {}\n{}", | ||
| self.name, version, min_version_to_display, self.helper_text | ||
| self.name, version, self.minimal_version, self.helper_text |
Member
Author
There was a problem hiding this comment.
There was a bug, minimal should be 2.13.1, not minimal_recommended 2.15.2
MKowalski8
force-pushed
the
mkowalski/3910-delete-check-for-ciaro-test-template
branch
2 times, most recently
from
af83a6b to
7bd7f5c
Compare
MKowalski8
force-pushed
the
mkowalski/3910-delete-check-for-ciaro-test-template
branch
from
7bd7f5c to
ae7a385
Compare
MKowalski8
changed the base branch from
master
to
mkowalski/remove-unused-features-flags
MKowalski8
force-pushed
the
mkowalski/remove-unused-features-flags
branch
from
82adec9 to
9450510
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3910
Introduced changes
SCARB_WITHOUT_CAIRO_TEST_TEMPLATEChecklist
CHANGELOG.md